[CLNP-6719] feat: mark-as-unread #244

OnestarLee · 2025-06-20T11:54:11Z

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-6719](https://sendbird.atlassian.net/browse/CLNP-6719)

Description Of Changes

Feature
- MarkAsUnread 기능 추가
  - NewLine UI 추가
  - UnreadMessageFloating 추가
  - BottomSheet 에 Mark as unread 메뉴 추가
Fix
- NewMessageButton 에서 새로운 메세지가 1개일때 new messages -> new message 로 문구 수정

Updated @sendbird/chat peerDependencies to v4.19.2

MarkAsUnread 스펙
https://sendbird.atlassian.net/wiki/spaces/SDK/pages/3191373873/MarkAsUnread
MarkAsUnread 기능 on/off 적용 되어있는 대시보드 접속 방법
https://sendbird.slack.com/archives/C08JD964GUS/p1750233883183979

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

codecov-commenter · 2025-06-20T11:56:25Z

Codecov Report

Attention: Patch coverage is 2.00000% with 196 lines in your changes missing coverage. Please review.

Project coverage is 11.27%. Comparing base (a99ff44) to head (2af1af8).

Files with missing lines	Patch %	Lines
...groupChannel/component/GroupChannelMessageList.tsx	0.00%	117 Missing ⚠️
...ative/src/fragments/createGroupChannelFragment.tsx	0.00%	31 Missing and 1 partial ⚠️
...native/src/components/ChannelMessageList/index.tsx	0.00%	23 Missing ⚠️
...act-native/src/localization/createBaseStringSet.ts	0.00%	11 Missing ⚠️
...nnelMessageRenderer/GroupChannelMessageNewLine.tsx	0.00%	6 Missing ⚠️
...t-native/src/components/UnreadMessagesFloating.tsx	0.00%	6 Missing ⚠️
...c/components/GroupChannelMessageRenderer/index.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   11.49%   11.27%   -0.23%     
==========================================
  Files         358      360       +2     
  Lines        8490     8676     +186     
  Branches     2395     2448      +53     
==========================================
+ Hits          976      978       +2     
- Misses       7439     7622     +183     
- Partials       75       76       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull Request Overview

This PR implements the new “mark as unread” feature for group channels while also updating various UI components and localization strings. In addition, the changes refine the Xcode project configuration and update dependencies for consistency.

Introduces new UI elements: NewLine indicator and UnreadMessagesFloating.
Adds localization string entries and type definitions for “mark as unread.”
Updates project signing settings and dependency versions.

Reviewed Changes

Copilot reviewed 17 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
sample/ios/SendbirdUIKitSample.xcodeproj/project.pbxproj	Added empty input/output paths and modified code signing settings.
packages/uikit-utils/package.json, packages/uikit-testing-tools/package.json, package.json, docs-validation/package.json	Updated @sendbird/chat dependency version.
packages/uikit-react-native/src/localization/createBaseStringSet.ts	Updated message pluralization and added new localized strings for unread message indicators.
packages/uikit-react-native/src/localization/StringSet.type.ts	Extended type definitions for the new mark-as-unread strings.
packages/uikit-react-native/src/fragments/createGroupChannelFragment.tsx	Added logic and refs to manage new line visibility and marking messages as unread.
packages/uikit-react-native/src/domain/groupChannel/*	Introduced handlers and refs for the mark-as-unread feature in message lists and press actions.
packages/uikit-react-native/src/components/*	Added new components for rendering the new line and unread messages floating UI.
packages/uikit-react-native-foundation/src/assets/icon/index.ts	Included an icon asset for “mark-as-unread.”

Comments suppressed due to low confidence (3)

packages/uikit-react-native/src/fragments/createGroupChannelFragment.tsx:95

[nitpick] Consider adding inline comments or JSDoc annotations to explain the purpose of 'isNewLineExistInChannelRef' and the related refs for new line tracking for clarity and maintainability.

    const isNewLineExistInChannelRef = useRef(false);

packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx:163

Ensure that all edge cases and interactions related to the new mark-as-unread functionality are adequately covered by unit and integration tests.

  const onPressMarkAsUnreadMessage = useCallback(

sample/ios/SendbirdUIKitSample.xcodeproj/project.pbxproj:583

The change from a developer-specific code signing identity to a generic one should be verified against your team's signing strategy to avoid unintended signing issues.

				CODE_SIGN_IDENTITY = "Apple Development";

sample/ios/SendbirdUIKitSample.xcodeproj/project.pbxproj

packages/uikit-react-native/package.json

OnestarLee · 2025-06-24T05:38:24Z

@bang9 sample 배포시에 사용하는 promiseofcake/circleci-trigger-action@v1 이 보안 정책으로 막혀서 curl 이용해서 직접 circleci 호출하도록 변경하였습니다

...uikit-react-native/src/components/GroupChannelMessageRenderer/GroupChannelMessageNewLine.tsx

packages/uikit-react-native/src/components/GroupChannelMessageRenderer/index.tsx

packages/uikit-react-native/src/components/UnreadMessagesFloating.tsx

OnestarLee · 2025-07-18T07:56:45Z

@bang9 qa 수정한 내용 머지하였습니다!

bang9 · 2025-07-21T19:44:05Z

packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx

+  const hasSeenNewLineRef = useRef(false);
+  const isNewLineInViewportRef = useRef(false);
+  const isNewLineExistInChannelRef = useRef(false);
+  const scrolledAwayFromBottomRef = useRef(false);
+  const [isVisibleUnreadMessageFloating, setIsVisibleUnreadMessageFloating] = useState(false);
+  const viewableMessages = useRef<SendbirdMessage[]>();
+  const hasUserMarkedAsUnreadRef = useRef(false);
+  const [unreadFirstMessage, setUnreadFirstMessage] = useState<SendbirdMessage | undefined>(undefined);


new line 관련 핸들링 하는것들을 한번 훅으로 묶어주는건 어떨까요? 그렇게 되면 복잡한 internal state/refs 를 노출하지 않고 핸들러들만 내보내거나 재활용을 할 수 있을 것 같아서 좋을 것 같습니다.

비슷한거로는 useMentionTextInput 훅이 있습니다!

scrolledAwayFromBottomRef 이런애들도 엮여있어서 좀 명확하게 분리가 안될 수도 있기는 하겠네요 ㅋㅋ

넵~ 안그래도 처음에 hook처럼 별도로 처리했는데, 관련 로직에 필요한 값들이 이것저것 엮이는게 많아서 그냥 합쳐서 처리하는걸로 다시 변경하였습니다. 의견 감사합니다!

packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx

bang9 · 2025-07-21T20:07:42Z

sample/src/context/uikitLocalConfigs.tsx

-  replyType: 'thread' as 'none' | 'thread' | 'quote_reply',
-  threadReplySelectType: 'thread' as 'thread' | 'parent',
+  replyType: 'quote_reply' as 'none' | 'thread' | 'quote_reply',
+  threadReplySelectType: 'parent' as 'thread' | 'parent',


요건 qa 때매 잠깐 바뀌는건가염?

QA테스트용으로 변경했는데 다시 롤백 하겠습니다

bang9

lgtm! 고생하셨습니다.

…arity

OnestarLee requested a review from Copilot June 20, 2025 12:16

This comment was marked as outdated.

Sign in to view

OnestarLee changed the title ~~feat/mark-as-unread~~ [CLNP-6719] mark-as-unread Jun 20, 2025

OnestarLee changed the title ~~[CLNP-6719] mark-as-unread~~ [CLNP-6719] feat:mark-as-unread Jun 20, 2025

OnestarLee changed the title ~~[CLNP-6719] feat:mark-as-unread~~ [CLNP-6719] feat: mark-as-unread Jun 20, 2025

OnestarLee force-pushed the feat/mark-as-unread branch from 20a7656 to 22cd7b3 Compare June 20, 2025 12:35

OnestarLee requested a review from Copilot June 20, 2025 12:36

Copilot AI reviewed Jun 20, 2025

View reviewed changes

sample/ios/SendbirdUIKitSample.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved

OnestarLee requested a review from bang9 June 20, 2025 12:36

bang9 reviewed Jun 20, 2025

View reviewed changes

packages/uikit-react-native/package.json Show resolved Hide resolved

OnestarLee force-pushed the feat/mark-as-unread branch from f7d1357 to b65b30b Compare June 30, 2025 02:15

bang9 reviewed Jun 30, 2025

View reviewed changes

...uikit-react-native/src/components/GroupChannelMessageRenderer/GroupChannelMessageNewLine.tsx Outdated Show resolved Hide resolved

bang9 reviewed Jun 30, 2025

View reviewed changes

packages/uikit-react-native/src/components/GroupChannelMessageRenderer/index.tsx Outdated Show resolved Hide resolved

bang9 reviewed Jun 30, 2025

View reviewed changes

packages/uikit-react-native/src/components/UnreadMessagesFloating.tsx Outdated Show resolved Hide resolved

bang9 reviewed Jun 30, 2025

View reviewed changes

packages/uikit-react-native/src/components/UnreadMessagesFloating.tsx Outdated Show resolved Hide resolved

bang9 force-pushed the feat/mark-as-unread branch from 28cd1c1 to 9650e6a Compare July 17, 2025 09:24

feat: add MarkAsUnread feature to GroupChannel

2df8c20

OnestarLee force-pushed the feat/mark-as-unread branch from 6adc82f to 2df8c20 Compare July 18, 2025 07:54

OnestarLee requested a review from bang9 July 18, 2025 07:56

chore: enhance touch target for close button in UnreadMessagesFloating

906eade

bang9 reviewed Jul 21, 2025

View reviewed changes

packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx Outdated Show resolved Hide resolved

bang9 reviewed Jul 21, 2025

View reviewed changes

bang9 approved these changes Jul 21, 2025

View reviewed changes

chore: rename findUnreadFirstMessage to findFirstUnreadMessage for cl…

2af1af8

…arity

OnestarLee added this pull request to the merge queue Jul 21, 2025

Merged via the queue into main with commit 3b13fd7 Jul 21, 2025
7 checks passed

OnestarLee deleted the feat/mark-as-unread branch July 21, 2025 23:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CLNP-6719] feat: mark-as-unread #244

[CLNP-6719] feat: mark-as-unread #244

Uh oh!

OnestarLee commented Jun 20, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Jun 20, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

OnestarLee commented Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OnestarLee commented Jul 18, 2025

Uh oh!

bang9 Jul 21, 2025

Uh oh!

bang9 Jul 21, 2025

Uh oh!

OnestarLee Jul 21, 2025

Uh oh!

Uh oh!

bang9 Jul 21, 2025

Uh oh!

OnestarLee Jul 21, 2025

Uh oh!

bang9 left a comment

Uh oh!

Uh oh!

Uh oh!

[CLNP-6719] feat: mark-as-unread #244

[CLNP-6719] feat: mark-as-unread #244

Uh oh!

Conversation

OnestarLee commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

External Contributions

For Internal Contributors

Description Of Changes

Types Of Changes

Uh oh!

codecov-commenter commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

OnestarLee commented Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OnestarLee commented Jul 18, 2025

Uh oh!

bang9 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

bang9 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

OnestarLee Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bang9 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

OnestarLee Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

bang9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

OnestarLee commented Jun 20, 2025 •

edited

Loading

codecov-commenter commented Jun 20, 2025 •

edited

Loading